Change results.Add to results.AddResult in endure, media metrics and media benchmark.

Change results.Add to results.AddResult in endure, media metrics and media benchmark.

BUG=383153
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276562

[tonyg, 2014-06-11 03:39:40]

Not clear what we're getting from this (as the callsites look more cluttered
without providing more structured data), but OK

lgtm

https://codereview.chromium.org/329723004/diff/1/tools/perf/benchmarks/media.py
File tools/perf/benchmarks/media.py (right):

https://codereview.chromium.org/329723004/diff/1/tools/perf/benchmarks/media....
tools/perf/benchmarks/media.py:9: from telemetry.value import
list_of_scalar_values
nit: alphabetize

https://codereview.chromium.org/329723004/diff/1/tools/perf/measurements/endu...
File tools/perf/measurements/endure.py (right):

https://codereview.chromium.org/329723004/diff/1/tools/perf/measurements/endu...
tools/perf/measurements/endure.py:96: results.current_page, trace_name + '_Y',
units_y, value_y))
Both are important=False

https://codereview.chromium.org/329723004/diff/1/tools/perf/metrics/media.py
File tools/perf/metrics/media.py (right):

https://codereview.chromium.org/329723004/diff/1/tools/perf/metrics/media.py#...
tools/perf/metrics/media.py:8: from telemetry.value import list_of_scalar_values
nit:alphabetize

[nednguyen, 2014-06-11 16:09:30]

On 2014/06/11 03:39:40, tonyg wrote:
> Not clear what we're getting from this (as the callsites look more cluttered
> without providing more structured data), but OK

I think the vision here is that the public interface of page_test_results should
have only 1 Add- method which is AddValue(...). All things such as success,
error, failure, metric numbers, file artifacts are considered to be
telemetry.value to be added. 

+Nat: Am I correct?

> lgtm
> 
>
https://codereview.chromium.org/329723004/diff/1/tools/perf/benchmarks/media.py
> File tools/perf/benchmarks/media.py (right):
> 
>
https://codereview.chromium.org/329723004/diff/1/tools/perf/benchmarks/media....
> tools/perf/benchmarks/media.py:9: from telemetry.value import
> list_of_scalar_values
> nit: alphabetize
> 
>
https://codereview.chromium.org/329723004/diff/1/tools/perf/measurements/endu...
> File tools/perf/measurements/endure.py (right):
> 
>
https://codereview.chromium.org/329723004/diff/1/tools/perf/measurements/endu...
> tools/perf/measurements/endure.py:96: results.current_page, trace_name + '_Y',
> units_y, value_y))
> Both are important=False
> 
> https://codereview.chromium.org/329723004/diff/1/tools/perf/metrics/media.py
> File tools/perf/metrics/media.py (right):
> 
>
https://codereview.chromium.org/329723004/diff/1/tools/perf/metrics/media.py#...
> tools/perf/metrics/media.py:8: from telemetry.value import
list_of_scalar_values
> nit:alphabetize

[nduca, 2014-06-11 19:48:22]

lgtm --- results.Add is deprecated ideally we get rid of all .Add calls...

[nednguyen, 2014-06-11 22:39:10]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-06-11 22:40:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/329723004/20001

[commit-bot: I haz the power, 2014-06-12 00:07:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15737)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18869)

[commit-bot: I haz the power, 2014-06-12 00:08:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:08:49]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15804)

[nednguyen, 2014-06-12 03:34:55]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-06-12 03:36:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/329723004/20001

[commit-bot: I haz the power, 2014-06-12 07:30:38]

Change committed as 276562