Change results.Add to results.AddResult in endure, media metrics and media benchmark.

tools/perf/benchmarks/media.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from measurements import media
 from telemetry import test
 from telemetry.page import page_measurement
+from telemetry.value import scalar
+from telemetry.value import list_of_scalar_values

[tonyg, 2014/06/11 03:39:39]

nit: alphabetize

 
 
 class _MSEMeasurement(page_measurement.PageMeasurement):
   def MeasurePage(self, page, tab, results):
     media_metric = tab.EvaluateJavaScript('window.__testMetrics')
     trace = media_metric['id'] if 'id' in media_metric else None
     metrics = media_metric['metrics'] if 'metrics' in media_metric else []
     for m in metrics:
+      trace_name = '%s.%s' % (m, trace)
       if isinstance(metrics[m], list):
-        values = [float(v) for v in metrics[m]]
+        results.AddValue(list_of_scalar_values.ListOfScalarValues(
+                results.current_page, trace_name, unit='ms',
+                values=[float(v) for v in metrics[m]],
+                important=True))
+
       else:
-        values = float(metrics[m])
-      results.Add(trace, 'ms', values, chart_name=m)
+        results.AddValue(scalar.ScalarValue(
+                results.current_page, trace_name, unit='ms',
+                value=float(metrics[m]), important=True))
 
 
 class Media(test.Test):
   """Obtains media metrics for key user scenarios."""
   test = media.Media
   page_set = 'page_sets/tough_video_cases.py'
 
 
 class MediaNetworkSimulation(test.Test):
   """Obtains media metrics under different network simulations."""
@@ skipping 39 matching lines @@
 class MediaSourceExtensions(test.Test):
   """Obtains media metrics for key media source extensions functions."""
   test = _MSEMeasurement
   page_set = 'page_sets/mse_cases.py'
 
   def CustomizeBrowserOptions(self, options):
     # Needed to allow XHR requests to return stream objects.
     options.AppendExtraBrowserArgs(
         ['--enable-experimental-web-platform-features',
          '--disable-gesture-requirement-for-media-playback'])