Change results.Add to results.AddResult in endure, media metrics and media benchmark.

tools/perf/metrics/media.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import logging
 import os
 
+from telemetry.value import scalar
+from telemetry.value import list_of_scalar_values

[tonyg, 2014/06/11 03:39:39]

nit:alphabetize

+
 from metrics import Metric
 
 
 class MediaMetric(Metric):
   """MediaMetric class injects and calls JS responsible for recording metrics.
 
   Default media metrics are collected for every media element in the page,
   such as decoded_frame_count, dropped_frame_count, decoded_video_bytes, and
   decoded_audio_bytes.
   """
@@ skipping 34 matching lines @@
           'decoded_bytes': 13233,
           ...
       }
     }
     """
     def AddOneResult(metric, unit):
       metrics = media_metric['metrics']
       for m in metrics:
         if m.startswith(metric):
           special_label = m[len(metric):]
+          trace_name = '%s.%s%s' % (metric, trace, special_label)
           if isinstance(metrics[m], list):
-            values = [float(v) for v in metrics[m]]
+            results.AddValue(list_of_scalar_values.ListOfScalarValues(
+                results.current_page, trace_name, unit,
+                values=[float(v) for v in metrics[m]],
+                important=True))
           else:
-            values = float(metrics[m])
-          results.Add(trace + special_label, unit, values,
-                      chart_name=metric, data_type='default')
+            results.AddValue(scalar.ScalarValue(
+                results.current_page, trace_name, unit, value=float(metrics[m]),
+                important=True))
 
     trace = media_metric['id']
     if not trace:
       logging.error('Metrics ID is missing in results.')
       return
 
     if not self._skip_basic_metrics:
       AddOneResult('buffering_time', 'ms')
       AddOneResult('decoded_audio_bytes', 'bytes')
       AddOneResult('decoded_video_bytes', 'bytes')
       AddOneResult('decoded_frame_count', 'frames')
       AddOneResult('dropped_frame_count', 'frames')
       AddOneResult('time_to_play', 'ms')
 
     AddOneResult('avg_loop_time', 'ms')
     AddOneResult('seek', 'ms')
     return trace