chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc - Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

index ce7179a2ec3a709e879f145502c3429e8457bacc..26ca85cb3d590ac19debdace1e1df55ef873a756 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

@@ -136,18 +136,21 @@ TEST_F(FileSystemProviderOperationsReadDirectoryTest, Execute) {

kEventName,

event->event_name);

base::ListValue* event_args = event->event_args.get();

- ASSERT_EQ(3u, event_args->GetSize());

+ ASSERT_EQ(1u, event_args->GetSize());

+ base::DictionaryValue* options = NULL;

+ ASSERT_TRUE(event_args->GetDictionary(0, &options));

std::string event_file_system_id;

- EXPECT_TRUE(event_args->GetString(0, &event_file_system_id));

+ EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));

EXPECT_EQ(kFileSystemId, event_file_system_id);

int event_request_id = -1;

- EXPECT_TRUE(event_args->GetInteger(1, &event_request_id));

+ EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));

EXPECT_EQ(kRequestId, event_request_id);

std::string event_directory_path;

- EXPECT_TRUE(event_args->GetString(2, &event_directory_path));

+ EXPECT_TRUE(options->GetString("directoryPath", &event_directory_path));

EXPECT_EQ(kDirectoryPath, event_directory_path);

}