Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 base::Unretained(&dispatcher))); 129 base::Unretained(&dispatcher)));
130 130
131 EXPECT_TRUE(read_directory.Execute(kRequestId)); 131 EXPECT_TRUE(read_directory.Execute(kRequestId));
132 132
133 ASSERT_EQ(1u, dispatcher.events().size()); 133 ASSERT_EQ(1u, dispatcher.events().size());
134 extensions::Event* event = dispatcher.events()[0]; 134 extensions::Event* event = dispatcher.events()[0];
135 EXPECT_EQ(extensions::api::file_system_provider::OnReadDirectoryRequested:: 135 EXPECT_EQ(extensions::api::file_system_provider::OnReadDirectoryRequested::
136 kEventName, 136 kEventName,
137 event->event_name); 137 event->event_name);
138 base::ListValue* event_args = event->event_args.get(); 138 base::ListValue* event_args = event->event_args.get();
139 ASSERT_EQ(3u, event_args->GetSize()); 139 ASSERT_EQ(1u, event_args->GetSize());
140
141 base::DictionaryValue* options = NULL;
142 ASSERT_TRUE(event_args->GetDictionary(0, &options));
140 143
141 std::string event_file_system_id; 144 std::string event_file_system_id;
142 EXPECT_TRUE(event_args->GetString(0, &event_file_system_id)); 145 EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
143 EXPECT_EQ(kFileSystemId, event_file_system_id); 146 EXPECT_EQ(kFileSystemId, event_file_system_id);
144 147
145 int event_request_id = -1; 148 int event_request_id = -1;
146 EXPECT_TRUE(event_args->GetInteger(1, &event_request_id)); 149 EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
147 EXPECT_EQ(kRequestId, event_request_id); 150 EXPECT_EQ(kRequestId, event_request_id);
148 151
149 std::string event_directory_path; 152 std::string event_directory_path;
150 EXPECT_TRUE(event_args->GetString(2, &event_directory_path)); 153 EXPECT_TRUE(options->GetString("directoryPath", &event_directory_path));
151 EXPECT_EQ(kDirectoryPath, event_directory_path); 154 EXPECT_EQ(kDirectoryPath, event_directory_path);
152 } 155 }
153 156
154 TEST_F(FileSystemProviderOperationsReadDirectoryTest, Execute_NoListener) { 157 TEST_F(FileSystemProviderOperationsReadDirectoryTest, Execute_NoListener) {
155 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */); 158 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
156 CallbackLogger callback_logger; 159 CallbackLogger callback_logger;
157 160
158 ReadDirectory read_directory(NULL, 161 ReadDirectory read_directory(NULL,
159 file_system_info_, 162 file_system_info_,
160 base::FilePath::FromUTF8Unsafe(kDirectoryPath), 163 base::FilePath::FromUTF8Unsafe(kDirectoryPath),
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 264
262 ASSERT_EQ(1u, callback_logger.events().size()); 265 ASSERT_EQ(1u, callback_logger.events().size());
263 CallbackLogger::Event* event = callback_logger.events()[0]; 266 CallbackLogger::Event* event = callback_logger.events()[0];
264 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result()); 267 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
265 ASSERT_EQ(0u, event->entry_list().size()); 268 ASSERT_EQ(0u, event->entry_list().size());
266 } 269 }
267 270
268 } // namespace operations 271 } // namespace operations
269 } // namespace file_system_provider 272 } // namespace file_system_provider
270 } // namespace chromeos 273 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698