chrome/browser/chromeos/file_system_provider/operations/read_file.cc - Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleaned up. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_file.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file.cc

index 8d60fa98696dcfc3ddc04c13e98c8daee9d9a907..3f0d38677e8de42abb965616a922cebd4be93fcd 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_file.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file.cc

@@ -62,10 +62,10 @@ ReadFile::~ReadFile() {

}

bool ReadFile::Execute(int request_id) {

- scoped_ptr<base::ListValue> values(new base::ListValue);

- values->AppendInteger(file_handle_);

- values->AppendDouble(offset_);

- values->AppendInteger(length_);

+ scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);

+ values->SetInteger("openRequestId", file_handle_);

+ values->SetDouble("offset", offset_);

+ values->SetInteger("length", length_);

return SendEvent(

request_id,

extensions::api::file_system_provider::OnReadFileRequested::kEventName,