[Refactor] Replace kFullscreenUsesMinimalChromeKey with WindowState::hide_shelf_when_fullscreen()

Replace kFullscreenUsesMinimalChrome with ash::wm::WindowState::hide_shelf_when_fullscreen()

BUG=None
TEST=None
R=jamescook
TBR=sky (For trivial change in chrome/browser/notifications/fullscreen_notification_blocker.cc)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231398

[pkotwicz, 2013-10-23 16:01:06]

James, can you please take a look?
This is a subset of https://codereview.chromium.org/27458002/
I am posting this as a separate CL so that I can unblock myself on subsequent
CLs. (I suspect that resolving Ben's concerns may take a while)

On a separate note, I am thinking about making tab fullscreen the same as
browser immersive fullscreen + presentation mode. That's the current behavior on
Mac.
HOWEVER, I need to discuss with rohitrao.  (He is working on
--enable-simplified-fullscreen which disable presentation mode on Mac
completely)

[pkotwicz, 2013-10-23 16:02:13]

*"browser immersive fullscreen + presentation mode" -> "browser immersive
fullscreen + tab fullscreen"

[James Cook, 2013-10-23 17:05:07]

LGTM with one suggestion about naming that I didn't think of before.

I don't feel particularly strongly about harmonizing with Mac.  If you've got
other work to do I might defer doing it.

https://codereview.chromium.org/32943006/diff/20001/ash/wm/wm_types.h
File ash/wm/wm_types.h (right):

https://codereview.chromium.org/32943006/diff/20001/ash/wm/wm_types.h#newcode68
ash/wm/wm_types.h:68: FULLSCREEN_TYPE_OTHER,
I think this might be clearer as FULLSCREEN_TYPE_FULL or
FULLSCREEN_TYPE_TRADITIONAL (or just FULLSCREEN_TYPE_DEFAULT).  The existing
name makes me thing it's "not really fullscreen" whereas it's actually our
traditional fullscreen.

[James Cook, 2013-10-23 17:09:44]

btw, good idea to break the patch into two to unblock yourself. I've seen people
get stuck for a long time on refactors added in the middle of review

[oshima, 2013-10-25 15:21:32]

https://codereview.chromium.org/32943006/diff/20001/ash/shelf/shelf_layout_ma...
File ash/shelf/shelf_layout_manager.cc (right):

https://codereview.chromium.org/32943006/diff/20001/ash/shelf/shelf_layout_ma...
ash/shelf/shelf_layout_manager.cc:547:
wm::FULLSCREEN_TYPE_IMMERSIVE_MINIMAL_CHROME;
Is this only place this fullscreen type is used in ash?

I believe "immersive mode" is chrome concept and there is no "immersive mode" in
ash, correct? If so, I think this should be "use_autohide_shelf" flag instead,
and immesive mode info should be kept in chrome side.

[pkotwicz, 2013-10-25 18:27:11]

After discussing at length with oshima@, we have decided that it is best for him
to complete the refactors he is working on
(https://codereview.chromium.org/38073004/) first before proceeding with this
CL. His CL may require significant changes to this CL.
In the mean time I will:
- Continue working on moving ImmersiveModeControllerAsh to the ash namespace
- Write up a doc about all of the possible fullscreen states for v1 and v2 apps

[pkotwicz, 2013-10-25 18:28:39]

After discussing at length with oshima@, we have decided that it is best for him
to complete the refactors he is working on
(https://codereview.chromium.org/42353002/) first before proceeding with this
CL. His CL may require significant changes to this CL.
In the mean time I will:
- Continue working on moving ImmersiveModeControllerAsh to the ash namespace
- Write up a doc about all of the possible fullscreen states for v1 and v2 apps

[pkotwicz, 2013-10-26 02:36:07]

James, can you please take another look?

This CL is now trivial, but I might as well get it out of the way

[James Cook, 2013-10-28 16:21:26]

LGTM

[commit-bot: I haz the power, 2013-10-28 16:51:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/32943006/270001

[commit-bot: I haz the power, 2013-10-28 17:10:05]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-10-28 17:12:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/32943006/270001

[oshima, 2013-10-28 17:59:25]

lgtm thanks!

[commit-bot: I haz the power, 2013-10-28 20:29:38]

Change committed as 231398