[Refactor] Replace kFullscreenUsesMinimalChromeKey with WindowState::hide_shelf_when_fullscreen()

ash/wm/wm_types.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WM_TYPES_H_
 #define ASH_WM_WM_TYPES_H_
 
 #include "ui/base/ui_base_types.h"
 
 namespace ash {
@@ skipping 28 matching lines @@
   // due to new window, for example).
   SHOW_TYPE_AUTO_POSITIONED,
 };
 
 // Utility functions to convert WindowShowType <-> ui::WindowShowState.
 // Note: LEFT/RIGHT MAXIMIZED, AUTO_POSITIONED type will be lost when
 // converting to ui::WindowShowState.
 WindowShowType ToWindowShowType(ui::WindowShowState state);
 ui::WindowShowState ToWindowShowState(WindowShowType type);
 
-}  // namespace
-}  // namespace
+// This enum defines the types of fullscreen. It is only relevant when
+// WindowShowType == SHOW_TYPE_FULLSCREEN.
+enum FullscreenType {
+  // - Light bars are used instead of regular tabs when the top-of-window views
+  // are hidden. The user can reveal the top-of-window views by hovering the
+  // mouse at top of the screen.
+  // - The shelf is forced to auto hide.
+  FULLSCREEN_TYPE_IMMERSIVE_MINIMAL_CHROME,
+
+  // - The tab strip is hidden when the top-of-window views are hidden. The
+  //   user can reveal the top-of-window views by hovering the
+  //   mouse at the top of the screen.
+  // - The shelf is completely hidden and cannot be revealed.
+  FULLSCREEN_TYPE_IMMERSIVE_NO_CHROME,
+
+  // - The tab strip is hidden and the top-of-window views cannot be revealed.
+  // - The shelf is completely hidden and cannot be revealed.
+  // - There may be a bubble which slides out when the user hovers the mouse at
+  //   top of the screen.
+  FULLSCREEN_TYPE_OTHER,

[James Cook, 2013/10/23 17:05:07]

I think this might be clearer as FULLSCREEN_TYPE_FULL or
FULLSCREEN_TYPE_TRADITIONAL (or just FULLSCREEN_TYPE_DEFAULT).  The existing
name makes me thing it's "not really fullscreen" whereas it's actually our
traditional fullscreen.

+
+  FULLSCREEN_TYPE_DEFAULT = FULLSCREEN_TYPE_OTHER
+};
+
+}  // namespace wm
+}  // namespace ash
 
 #endif  // ASH_WM_WM_TYPES_H_