[DevTools] Fix crash on Mac when toolbox web contents are present.

[DevTools] Fix crash on Mac when toolbox web contents are present.

Unfortunately, toolbox WebContents may be referenced by browser
window on Mac while undocked DevToolsWindow is being destroyed.

Destroying toolbox WebContents after browser window update fixes this.

BUG=382502
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276604

[dgozman, 2014-06-11 15:18:12]

Take a look please.

[vsevik, 2014-06-11 15:36:06]

lgtm

https://chromiumcodereview.appspot.com/329193002/diff/1/chrome/browser/devtoo...
File chrome/browser/devtools/devtools_window.cc (right):

https://chromiumcodereview.appspot.com/329193002/diff/1/chrome/browser/devtoo...
chrome/browser/devtools/devtools_window.cc:245: if (toolbox_web_contents_)
Is it possible that toolbox_web_contents_ being set in DevToolsWindow somehow
affects behavior of the Update* routines?
Consider doing the following
WebContents* toolbox_web_contents = toolbox_web_contents_;
Update*();
if (toolbox_web_contents)
  delete toolbox_web_contents;

[vsevik, 2014-06-11 15:41:30]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-06-11 15:44:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/329193002/1

[commit-bot: I haz the power, 2014-06-11 20:11:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:00:34]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[pfeldman, 2014-06-12 04:36:53]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-06-12 04:40:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgozman@chromium.org/329193002/1

[commit-bot: I haz the power, 2014-06-12 09:36:41]

Change committed as 276604