[DevTools] Fix crash on Mac when toolbox web contents are present.

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_window.h"
 
 #include <algorithm>
 
 #include "base/json/json_reader.h"
 #include "base/metrics/histogram.h"
@@ skipping 221 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DevToolsToolboxDelegate);
 };
 
 // DevToolsWindow -------------------------------------------------------------
 
 const char DevToolsWindow::kDevToolsApp[] = "DevToolsApp";
 
 DevToolsWindow::~DevToolsWindow() {
+  UpdateBrowserWindow();
+  UpdateBrowserToolbar();
+
   if (toolbox_web_contents_)

[vsevik, 2014/06/11 15:36:06]

Is it possible that toolbox_web_contents_ being set in DevToolsWindow somehow
affects behavior of the Update* routines?
Consider doing the following
WebContents* toolbox_web_contents = toolbox_web_contents_;
Update*();
if (toolbox_web_contents)
  delete toolbox_web_contents;

     delete toolbox_web_contents_;
-  UpdateBrowserWindow();
-  UpdateBrowserToolbar();
 
   DevToolsWindows* instances = g_instances.Pointer();
   DevToolsWindows::iterator it(
       std::find(instances->begin(), instances->end(), this));
   DCHECK(it != instances->end());
   instances->erase(it);
 }
 
 // static
 std::string DevToolsWindow::GetDevToolsWindowPlacementPrefKey() {
@@ skipping 969 matching lines @@
       closure.Run();
     return;
   }
   load_completed_callback_ = closure;
 }
 
 bool DevToolsWindow::ForwardKeyboardEvent(
     const content::NativeWebKeyboardEvent& event) {
   return event_forwarder_->ForwardEvent(event);
 }