Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 329193002: [DevTools] Fix crash on Mac when toolbox web contents are present. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index ca77570cc58386e0b9419af254bcacf0313800f9..2b061d2eeb13f7a584414994150b2b41bf320794 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -239,11 +239,12 @@ class DevToolsToolboxDelegate
const char DevToolsWindow::kDevToolsApp[] = "DevToolsApp";
DevToolsWindow::~DevToolsWindow() {
- if (toolbox_web_contents_)
- delete toolbox_web_contents_;
UpdateBrowserWindow();
UpdateBrowserToolbar();
+ if (toolbox_web_contents_)
vsevik 2014/06/11 15:36:06 Is it possible that toolbox_web_contents_ being se
+ delete toolbox_web_contents_;
+
DevToolsWindows* instances = g_instances.Pointer();
DevToolsWindows::iterator it(
std::find(instances->begin(), instances->end(), this));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698