SSL Connect Job Waiting

net/socket/ssl_client_socket.cc

Index: net/socket/ssl_client_socket.cc
diff --git a/net/socket/ssl_client_socket.cc b/net/socket/ssl_client_socket.cc
index 1b2fe144304955bd0c423aca96d90226c45d7f4a..de0ad7658f69dfc5d7c5656ec59de6088b9f47eb 100644
--- a/net/socket/ssl_client_socket.cc
+++ b/net/socket/ssl_client_socket.cc
@@ -103,6 +103,12 @@ NextProto SSLClientSocket::GetNegotiatedProtocol() const {
   return protocol_negotiated_;
 }
 
+bool SSLClientSocket::InSessionCache() const {

[wtc, 2014/06/19 19:38:10]

Remove the definition of SSLClientSocket::InSessionCache(). Declare
SSLClientSocket::InSessionCache() as abstract (= 0) in the .h file.

This means we'll need to define InSessionCache() in all subclasses of
SSLClientSocket. This is a hassle, but is appropriate in this case because the
SSL session cache is very specific to the implementation of SSLClientSocket.

[mshelley1, 2014/06/24 17:03:59]

Done.

+  // We expect to invoke this method in the SSLClientSocketOpenSSL
+  NOTREACHED();
+  return false;

[wtc, 2014/06/19 19:38:10]

To suppress your feature, this method actually needs to return true. This is
counter-intuitive, so please add a comment.

+}
+
 bool SSLClientSocket::IgnoreCertError(int error, int load_flags) {
   if (error == OK || load_flags & LOAD_IGNORE_ALL_CERT_ERRORS)
     return true;