Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/ssl_client_socket.h

Issue 328903004: SSL Connect Job Waiting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed bugs related to memory management and early exits in DoSSLConnectComplete Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | net/socket/ssl_client_socket.cc » ('j') | net/socket/ssl_client_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index a43e58cc26b852fb86d92a1a5ac7c4e7c357b286..20b51e68d9b00139bb2a08f0712114eecde63409 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -81,6 +81,13 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
virtual bool WasNpnNegotiated() const OVERRIDE;
virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
+ // Returns true if there is a cache entry in the ssl session cache
+ // for the given |cache key|.
+ //
+ // |cache_key| consists of an SSLConnectJobs host_and_port name
+ // concatenated with its session cache shard.
wtc 2014/06/19 19:38:10 Since this method doesn't have a |cache_key| param
mshelley1 2014/06/24 17:03:59 Done.
+ virtual bool InSessionCache() const;
wtc 2014/06/19 19:38:10 Could you declare this virtual method as abstract
mshelley1 2014/06/24 17:03:59 Done.
+
// Gets the SSL CertificateRequest info of the socket after Connect failed
// with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.
virtual void GetSSLCertRequestInfo(
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | net/socket/ssl_client_socket.cc » ('j') | net/socket/ssl_client_socket.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698