net/socket/ssl_client_socket_openssl.h - Issue 328903004: SSL Connect Job Waiting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.h

Issue 328903004: SSL Connect Job Waiting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bugs related to memory management and early exits in DoSSLConnectComplete Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/ssl_client_socket_openssl.h

diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h

index 5d70c0523fabe0230b2361f7418688f1215fe0df..92038981007c4523225823bf4570f3237d1f7042 100644

--- a/net/socket/ssl_client_socket_openssl.h

+++ b/net/socket/ssl_client_socket_openssl.h

@@ -62,6 +62,7 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {

virtual NextProtoStatus GetNextProto(std::string* proto,

std::string* server_protos) OVERRIDE;

virtual ServerBoundCertService* GetServerBoundCertService() const OVERRIDE;

+ virtual bool InSessionCache() const OVERRIDE;

wtc 2014/06/19 19:38:10 Nit: move this declaration right before GetSSLCert

mshelley1 2014/06/24 17:03:59 Done.

// SSLSocket implementation.

virtual int ExportKeyingMaterial(const base::StringPiece& label,