SSL Connect Job Waiting

net/socket/ssl_client_socket_openssl.h

Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index 5d70c0523fabe0230b2361f7418688f1215fe0df..32e4400d9431e5387aa4b65234762702c978d737 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -39,7 +39,7 @@ class SSLCertRequestInfo;
 class SSLInfo;
 
 // An SSL client socket implemented with OpenSSL.
-class SSLClientSocketOpenSSL : public SSLClientSocket {
+class NET_EXPORT SSLClientSocketOpenSSL : public SSLClientSocket {

[wtc, 2014/06/13 22:47:24]

Use NET_EXPORT_PRIVATE if it is exported for net_unittests only.

[mshelley1, 2014/06/16 19:02:49]

I think I included NET_EXPORT when I was attempting to solve a linker error with
the InSessionCache function, and forgot to take it out after I fixed it. As it
turns out I don't think I need it at all.

  public:
   // Takes ownership of the transport_socket, which may already be connected.
   // The given hostname will be compared with the name(s) in the server's
@@ -57,6 +57,7 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
   }
 
   // SSLClientSocket implementation.
+  static bool InSessionCache(std::string cache_key);

[wtc, 2014/06/13 22:47:24]

1. This method should not be in the "SSLClientSocket implementation" section
because it is not a virtual method of SSLClientSocket.

2. The |cache_key| parameter should be a const reference.

3. Please document this method. In particular, the format of |cache_key|.

4. An alternative design is to add a static getter method that returns a pointer
to the session cache. But I guess that is overly OpenSSL-specific? (There is no
stand-alone session cache class for SSLClientSocketNSS.)

[mshelley1, 2014/06/16 19:02:49]

Done.

   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) OVERRIDE;
   virtual NextProtoStatus GetNextProto(std::string* proto,