SSL Connect Job Waiting

net/socket/ssl_client_socket.cc

Index: net/socket/ssl_client_socket.cc
diff --git a/net/socket/ssl_client_socket.cc b/net/socket/ssl_client_socket.cc
index 1b2fe144304955bd0c423aca96d90226c45d7f4a..eb8b369fe0ee44e91460a45e6ad6f346d3c6cf79 100644
--- a/net/socket/ssl_client_socket.cc
+++ b/net/socket/ssl_client_socket.cc
@@ -103,6 +103,12 @@ NextProto SSLClientSocket::GetNegotiatedProtocol() const {
   return protocol_negotiated_;
 }
 
+bool SSLClientSocket::InSessionCache(std::string cache_key) {
+  // We expect to invoke this method in the SSLClientSocketOpenSSL

[wtc, 2014/06/13 22:47:24]

This is a static method. Virtual methods cannot be static. So if we want to have
a SSLClientSocket::InSessionCache method, it needs to be defined like this:

bool SSLClientSocket::InSessionCache(const std::string& cache_key) {
#if defined(USE_OPENSSL)
  return SSLClientSocketSSL::InSessionCache(cache_key);
#else
  NOTREACHED();  // You can also use the NOTIMPLEMENTED() macro.
  return false;
#endif
}

[Ryan Sleevi, 2014/06/13 23:24:22]

Note that while Wan-Teh's suggestion is a valid approach, we've tried to avoid
coupling SSLClientSocket with it's derived implementations, because it creates a
circular dependency.

That is, SSLClientSocket would now need SSLClientSocketOpenSSL in order to
implement its required features, and SSLClientSocketOpenSSL already needs
SSLClientSocket in order to implement its required features.

[mshelley1, 2014/06/16 19:02:49]

Done.

+  NOTREACHED();
+  return false;
+}
+
 bool SSLClientSocket::IgnoreCertError(int error, int load_flags) {
   if (error == OK || load_flags & LOAD_IGNORE_ALL_CERT_ERRORS)
     return true;