SSL Connect Job Waiting

net/socket/ssl_client_socket_openssl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 21 matching lines @@
 typedef struct x509_store_ctx_st X509_STORE_CTX;
 
 namespace net {
 
 class CertVerifier;
 class SingleRequestCertVerifier;
 class SSLCertRequestInfo;
 class SSLInfo;
 
 // An SSL client socket implemented with OpenSSL.
-class SSLClientSocketOpenSSL : public SSLClientSocket {
+class NET_EXPORT SSLClientSocketOpenSSL : public SSLClientSocket {

[wtc, 2014/06/13 22:47:24]

Use NET_EXPORT_PRIVATE if it is exported for net_unittests only.

[mshelley1, 2014/06/16 19:02:49]

I think I included NET_EXPORT when I was attempting to solve a linker error with
the InSessionCache function, and forgot to take it out after I fixed it. As it
turns out I don't think I need it at all.

  public:
   // Takes ownership of the transport_socket, which may already be connected.
   // The given hostname will be compared with the name(s) in the server's
   // certificate during the SSL handshake.  ssl_config specifies the SSL
   // settings.
   SSLClientSocketOpenSSL(scoped_ptr<ClientSocketHandle> transport_socket,
                          const HostPortPair& host_and_port,
                          const SSLConfig& ssl_config,
                          const SSLClientSocketContext& context);
   virtual ~SSLClientSocketOpenSSL();
 
   const HostPortPair& host_and_port() const { return host_and_port_; }
   const std::string& ssl_session_cache_shard() const {
     return ssl_session_cache_shard_;
   }
 
   // SSLClientSocket implementation.
+  static bool InSessionCache(std::string cache_key);

[wtc, 2014/06/13 22:47:24]

1. This method should not be in the "SSLClientSocket implementation" section
because it is not a virtual method of SSLClientSocket.

2. The |cache_key| parameter should be a const reference.

3. Please document this method. In particular, the format of |cache_key|.

4. An alternative design is to add a static getter method that returns a pointer
to the session cache. But I guess that is overly OpenSSL-specific? (There is no
stand-alone session cache class for SSLClientSocketNSS.)

[mshelley1, 2014/06/16 19:02:49]

Done.

   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) OVERRIDE;
   virtual NextProtoStatus GetNextProto(std::string* proto,
                                        std::string* server_protos) OVERRIDE;
   virtual ServerBoundCertService* GetServerBoundCertService() const OVERRIDE;
 
   // SSLSocket implementation.
   virtual int ExportKeyingMaterial(const base::StringPiece& label,
                                    bool has_context,
                                    const base::StringPiece& context,
@@ skipping 171 matching lines @@
   // True if channel ID extension was negotiated.
   bool channel_id_xtn_negotiated_;
   // The request handle for |server_bound_cert_service_|.
   ServerBoundCertService::RequestHandle channel_id_request_handle_;
   BoundNetLog net_log_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_