SSL Connect Job Waiting

net/socket/ssl_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_client_socket.h"
 
 #include "base/metrics/histogram.h"
 #include "base/strings/string_util.h"
 #include "crypto/ec_private_key.h"
 #include "net/ssl/server_bound_cert_service.h"
@@ skipping 85 matching lines @@
 }
 
 bool SSLClientSocket::WasNpnNegotiated() const {
   return was_npn_negotiated_;
 }
 
 NextProto SSLClientSocket::GetNegotiatedProtocol() const {
   return protocol_negotiated_;
 }
 
+bool SSLClientSocket::InSessionCache(std::string cache_key) {
+  // We expect to invoke this method in the SSLClientSocketOpenSSL

[wtc, 2014/06/13 22:47:24]

This is a static method. Virtual methods cannot be static. So if we want to have
a SSLClientSocket::InSessionCache method, it needs to be defined like this:

bool SSLClientSocket::InSessionCache(const std::string& cache_key) {
#if defined(USE_OPENSSL)
  return SSLClientSocketSSL::InSessionCache(cache_key);
#else
  NOTREACHED();  // You can also use the NOTIMPLEMENTED() macro.
  return false;
#endif
}

[Ryan Sleevi, 2014/06/13 23:24:22]

Note that while Wan-Teh's suggestion is a valid approach, we've tried to avoid
coupling SSLClientSocket with it's derived implementations, because it creates a
circular dependency.

That is, SSLClientSocket would now need SSLClientSocketOpenSSL in order to
implement its required features, and SSLClientSocketOpenSSL already needs
SSLClientSocket in order to implement its required features.

[mshelley1, 2014/06/16 19:02:49]

Done.

+  NOTREACHED();
+  return false;
+}
+
 bool SSLClientSocket::IgnoreCertError(int error, int load_flags) {
   if (error == OK || load_flags & LOAD_IGNORE_ALL_CERT_ERRORS)
     return true;
 
   if (error == ERR_CERT_COMMON_NAME_INVALID &&
       (load_flags & LOAD_IGNORE_CERT_COMMON_NAME_INVALID))
     return true;
 
   if (error == ERR_CERT_DATE_INVALID &&
       (load_flags & LOAD_IGNORE_CERT_DATE_INVALID))
@@ skipping 88 matching lines @@
   }
   if (!server_bound_cert_service->IsSystemTimeValid()) {
     DVLOG(1) << "System time is not within the supported range for certificate "
                 "generation, not enabling channel ID.";
     return false;
   }
   return true;
 }
 
 }  // namespace net