Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 328753003: Mojo: Plumb MojoCreateMessagePipeOptions through to the C++ wrappers. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Plumb MojoCreateMessagePipeOptions through to the C++ wrappers. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276707

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M mojo/common/message_pump_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/handle_passing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/core.h View 3 chunks +12 lines, -4 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/spy/spy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/324783002/ and https://codereview.chromium.org/328713004/.)
6 years, 6 months ago (2014-06-10 17:15:43 UTC) #1
viettrungluu
ping
6 years, 6 months ago (2014-06-11 16:35:28 UTC) #2
viettrungluu
-> yzshen instead
6 years, 6 months ago (2014-06-11 20:46:32 UTC) #3
yzshen1
lgtm
6 years, 6 months ago (2014-06-11 20:51:29 UTC) #4
viettrungluu
6 years, 6 months ago (2014-06-12 16:29:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r276707 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698