Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328713006: Merge 275988 "Move about://-related constants from //content to ..." (Closed)

Created:
6 years, 6 months ago by kerz_chromium
Modified:
6 years, 6 months ago
Reviewers:
blundell
CC:
chromium-reviews, asanka, skanuj+watch_chromium.org, felt, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, alecflett, dougw+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, ericu+idb_chromium.org, dgrogan, dmazzoni+watch_chromium.org, markusheintz_, aandrey+blink_chromium.org, dhollowa+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, melevin+watch_chromium.org, aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, jam, dyu1, dominich, marja+watch_chromium.org, benquan, darin-cc_chromium.org, Jered, devtools-reviews_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, dbeam+watch-options_chromium.org, jennb, creis+watch_chromium.org, cmumford, jianli, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, samarth+watch_chromium.org, paulirish+reviews_chromium.org, dcheng, oshima+watch_chromium.org, estade+watch_chromium.org, jsbell+idb_chromium.org, jochen+watch_chromium.org, davidben+watch_chromium.org, Ilya Sherman, plundblad+watch_chromium.org, gavinp+prer_chromium.org, davemoore+watch_chromium.org, tfarina, donnd+watch_chromium.org, Dmitry Titov, yurys, benjhayden+dwatch_chromium.org, dominich+watch_chromium.org, jfweitz+watch_chromium.org, David Black, Dane Wallinga, dtseng+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, pfeldman
Visibility:
Public.

Description

Merge 275988 "Move about://-related constants from //content to ..." > Move about://-related constants from //content to //url > > kAboutScheme and kAboutBlankURL are used in code shared by iOS, and are general > enough to live in //url instead of //content. > > TBR=yoz,benm > > Review URL: https://codereview.chromium.org/325443002 TBR=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -329 lines) Patch
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M apps/launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_browsertest.cc View 5 chunks +11 lines, -19 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/autofill/content_autofill_driver_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/uma_policy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 7 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/sessions/better_session_restore_browsertest.cc View 6 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_focus_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabrestore_browsertest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_interactive_browsertest.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc View 14 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/singleton_tabs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/origin_chip_info.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/accessibility/browser_views_accessibility_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/bookmarks/browser/bookmark_index_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/android_hit_testing_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/webui/web_ui_controller_factory_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/url_constants.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/public/test/content_browser_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_application_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/script_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M url/url_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M url/url_constants.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kerz_chromium
6 years, 6 months ago (2014-06-10 19:23:34 UTC) #1
kerz_chromium
Committed patchset #1 manually as r276114 (tree was closed).
6 years, 6 months ago (2014-06-10 19:26:34 UTC) #2
blundell
6 years, 6 months ago (2014-06-11 13:16:15 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698