components/bookmarks/browser/bookmark_index_unittest.cc - Issue 328713006: Merge 275988 "Move about://-related constants from //content to ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_index_unittest.cc

Issue 328713006: Merge 275988 "Move about://-related constants from //content to ..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2042/src/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/utility/importer/bookmarks_file_importer.cc ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_index_unittest.cc

===================================================================

--- components/bookmarks/browser/bookmark_index_unittest.cc (revision 276109)

+++ components/bookmarks/browser/bookmark_index_unittest.cc (working copy)

@@ -368,7 +368,7 @@

// Makes sure index is updated when a node is removed.

TEST_F(BookmarkIndexTest, Remove) {

const char* titles[] = { "a", "b" };

- const char* urls[] = { kAboutBlankURL, kAboutBlankURL };

+ const char* urls[] = {kAboutBlankURL, kAboutBlankURL};

AddBookmarks(titles, urls, ARRAYSIZE_UNSAFE(titles));

// Remove the node and make sure we don't get back any results.

@@ -379,7 +379,7 @@

// Makes sure index is updated when a node's title is changed.

TEST_F(BookmarkIndexTest, ChangeTitle) {

const char* titles[] = { "a", "b" };

- const char* urls[] = { kAboutBlankURL, kAboutBlankURL };

+ const char* urls[] = {kAboutBlankURL, kAboutBlankURL};

AddBookmarks(titles, urls, ARRAYSIZE_UNSAFE(titles));

// Remove the node and make sure we don't get back any results.

@@ -391,7 +391,7 @@

// Makes sure no more than max queries is returned.

TEST_F(BookmarkIndexTest, HonorMax) {

const char* titles[] = { "abcd", "abcde" };

- const char* urls[] = { kAboutBlankURL, kAboutBlankURL };

+ const char* urls[] = {kAboutBlankURL, kAboutBlankURL};

AddBookmarks(titles, urls, ARRAYSIZE_UNSAFE(titles));

std::vector<BookmarkMatch> matches;