chrome/browser/extensions/api/tabs/tabs_test.cc - Issue 328713006: Merge 275988 "Move about://-related constants from //content to ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 328713006: Merge 275988 "Move about://-related constants from //content to ..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2042/src/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/uma_policy.cc ('k') | chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_test.cc

===================================================================

--- chrome/browser/extensions/api/tabs/tabs_test.cc (revision 276109)

+++ chrome/browser/extensions/api/tabs/tabs_test.cc (working copy)

@@ -393,7 +393,7 @@

for (size_t i = 0; i < kExtraWindows; ++i)

CreateBrowser(browser()->profile());

- GURL url(content::kAboutBlankURL);

+ GURL url(url::kAboutBlankURL);

AddTabAtIndexToBrowser(browser(), 0, url, content::PAGE_TRANSITION_LINK);

int window_id = ExtensionTabUtil::GetWindowId(browser());

@@ -510,10 +510,11 @@

}

IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DuplicateTab) {

- content::OpenURLParams params(GURL(content::kAboutBlankURL),

+ content::OpenURLParams params(GURL(url::kAboutBlankURL),

content::Referrer(),

NEW_FOREGROUND_TAB,

- content::PAGE_TRANSITION_LINK, false);

+ content::PAGE_TRANSITION_LINK,

+ false);

content::WebContents* web_contents = browser()->OpenURL(params);

int tab_id = ExtensionTabUtil::GetTabId(web_contents);

int window_id = ExtensionTabUtil::GetWindowIdOfTab(web_contents);

@@ -553,10 +554,11 @@

}

IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, DuplicateTabNoPermission) {