Do not de-reference Profile on the IO thread in BrowsingDataRemover.

Do not de-reference Profile on the IO thread in BrowsingDataRemover::ClearNetworkPredictorOnIOThread.

BUG=365030
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276449

[engedy, 2014-06-10 10:21:55]

@Mike, @Ryan: please take a a look.

[Mike West, 2014-06-10 12:33:13]

https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
File chrome/browser/browsing_data/browsing_data_remover.cc (left):

https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
chrome/browser/browsing_data/browsing_data_remover.cc:871: if (predictor) {
Can this be null? If not, can we DCHECK?

[engedy, 2014-06-10 15:19:40]

https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
File chrome/browser/browsing_data/browsing_data_remover.cc (left):

https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
chrome/browser/browsing_data/browsing_data_remover.cc:871: if (predictor) {
On 2014/06/10 12:33:13, Mike West wrote:
> Can this be null? If not, can we DCHECK?

Indeed, this must be non-NULL, otherwise the method would not be called. Added a
DCHECK.

[engedy, 2014-06-10 15:20:20]

On 2014/06/10 15:19:40, engedy wrote:
>
https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
> File chrome/browser/browsing_data/browsing_data_remover.cc (left):
> 
>
https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
> chrome/browser/browsing_data/browsing_data_remover.cc:871: if (predictor) {
> On 2014/06/10 12:33:13, Mike West wrote:
> > Can this be null? If not, can we DCHECK?
> 
> Indeed, this must be non-NULL, otherwise the method would not be called. Added
a
> DCHECK.

I mean, this *will* be non-NULL.

[Mike West, 2014-06-10 15:31:41]

On 2014/06/10 at 15:20:20, engedy wrote:
> On 2014/06/10 15:19:40, engedy wrote:
> >
https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
> > File chrome/browser/browsing_data/browsing_data_remover.cc (left):
> > 
> >
https://codereview.chromium.org/328703002/diff/1/chrome/browser/browsing_data...
> > chrome/browser/browsing_data/browsing_data_remover.cc:871: if (predictor) {
> > On 2014/06/10 12:33:13, Mike West wrote:
> > > Can this be null? If not, can we DCHECK?
> > 
> > Indeed, this must be non-NULL, otherwise the method would not be called.
Added a
> > DCHECK.
> 
> I mean, this *will* be non-NULL.

LGTM, thanks.

[Ryan Sleevi, 2014-06-10 18:01:08]

I'm not familiar with this code, but it looks right to me :)

[engedy, 2014-06-11 08:22:06]

The CQ bit was checked by engedy@chromium.org

[engedy, 2014-06-11 08:22:12]

The CQ bit was unchecked by engedy@chromium.org

[engedy, 2014-06-11 08:23:35]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-06-11 08:26:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/328703002/20001

[commit-bot: I haz the power, 2014-06-11 14:28:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-11 18:03:53]

Change committed as 276449