Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 328703002: Do not de-reference Profile on the IO thread in BrowsingDataRemover. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added DCHECK. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 5 #ifndef CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 6 #define CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 #include "base/prefs/pref_member.h" 13 #include "base/prefs/pref_member.h"
14 #include "base/sequenced_task_runner_helpers.h" 14 #include "base/sequenced_task_runner_helpers.h"
15 #include "base/synchronization/waitable_event_watcher.h" 15 #include "base/synchronization/waitable_event_watcher.h"
16 #include "base/task/cancelable_task_tracker.h" 16 #include "base/task/cancelable_task_tracker.h"
17 #include "base/time/time.h" 17 #include "base/time/time.h"
18 #include "chrome/browser/pepper_flash_settings_manager.h" 18 #include "chrome/browser/pepper_flash_settings_manager.h"
19 #include "chrome/browser/search_engines/template_url_service.h" 19 #include "chrome/browser/search_engines/template_url_service.h"
20 #if defined(OS_CHROMEOS) 20 #if defined(OS_CHROMEOS)
21 #include "chromeos/dbus/dbus_method_call_status.h" 21 #include "chromeos/dbus/dbus_method_call_status.h"
22 #endif 22 #endif
23 #include "url/gurl.h" 23 #include "url/gurl.h"
24 #include "webkit/common/quota/quota_types.h" 24 #include "webkit/common/quota/quota_types.h"
25 25
26 class ExtensionSpecialStoragePolicy; 26 class ExtensionSpecialStoragePolicy;
27 class IOThread; 27 class IOThread;
28 class Profile; 28 class Profile;
29 29
30 namespace chrome_browser_net {
31 class Predictor;
32 }
33
30 namespace content { 34 namespace content {
31 class PluginDataRemover; 35 class PluginDataRemover;
32 class StoragePartition; 36 class StoragePartition;
33 } 37 }
34 38
35 namespace disk_cache { 39 namespace disk_cache {
36 class Backend; 40 class Backend;
37 } 41 }
38 42
39 namespace net { 43 namespace net {
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 // Clears the LoggedIn Predictor. 300 // Clears the LoggedIn Predictor.
297 void ClearLoggedInPredictor(); 301 void ClearLoggedInPredictor();
298 302
299 // Callback for when speculative data in the network Predictor has been 303 // Callback for when speculative data in the network Predictor has been
300 // cleared. Clears the respective waiting flag and invokes 304 // cleared. Clears the respective waiting flag and invokes
301 // NotifyAndDeleteIfDone. 305 // NotifyAndDeleteIfDone.
302 void OnClearedNetworkPredictor(); 306 void OnClearedNetworkPredictor();
303 307
304 // Invoked on the IO thread to clear speculative data related to hostname 308 // Invoked on the IO thread to clear speculative data related to hostname
305 // pre-resolution from the network Predictor. 309 // pre-resolution from the network Predictor.
306 void ClearNetworkPredictorOnIOThread(); 310 void ClearNetworkPredictorOnIOThread(
311 chrome_browser_net::Predictor* predictor);
307 312
308 // Callback for when network related data in ProfileIOData has been cleared. 313 // Callback for when network related data in ProfileIOData has been cleared.
309 // Clears the respective waiting flag and invokes NotifyAndDeleteIfDone. 314 // Clears the respective waiting flag and invokes NotifyAndDeleteIfDone.
310 void OnClearedNetworkingHistory(); 315 void OnClearedNetworkingHistory();
311 316
312 // Callback for when the cache has been deleted. Invokes 317 // Callback for when the cache has been deleted. Invokes
313 // NotifyAndDeleteIfDone. 318 // NotifyAndDeleteIfDone.
314 void ClearedCache(); 319 void ClearedCache();
315 320
316 // Invoked on the IO thread to delete from the cache. 321 // Invoked on the IO thread to delete from the cache.
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
458 463
459 scoped_ptr<TemplateURLService::Subscription> template_url_sub_; 464 scoped_ptr<TemplateURLService::Subscription> template_url_sub_;
460 465
461 // We do not own this. 466 // We do not own this.
462 content::StoragePartition* storage_partition_for_testing_; 467 content::StoragePartition* storage_partition_for_testing_;
463 468
464 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover); 469 DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
465 }; 470 };
466 471
467 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_ 472 #endif // CHROME_BROWSER_BROWSING_DATA_BROWSING_DATA_REMOVER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698