Do not de-reference Profile on the IO thread in BrowsingDataRemover.

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 294 matching lines @@
           base::Bind(
               &BrowsingDataRemover::ClearHostnameResolutionCacheOnIOThread,
               base::Unretained(this),
               g_browser_process->io_thread()));
     }
     if (profile_->GetNetworkPredictor()) {
       waiting_for_clear_network_predictor_ = true;
       BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
           base::Bind(&BrowsingDataRemover::ClearNetworkPredictorOnIOThread,
-                     base::Unretained(this)));
+                     base::Unretained(this),
+                     profile_->GetNetworkPredictor()));
     }
 
     // As part of history deletion we also delete the auto-generated keywords.
     TemplateURLService* keywords_model =
         TemplateURLServiceFactory::GetForProfile(profile_);
     if (keywords_model && !keywords_model->loaded()) {
       template_url_sub_ = keywords_model->RegisterOnLoadedCallback(
           base::Bind(&BrowsingDataRemover::OnKeywordsLoaded,
                      base::Unretained(this)));
       keywords_model->Load();
@@ skipping 531 matching lines @@
       base::Bind(&BrowsingDataRemover::OnClearedLoggedInPredictor,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedNetworkPredictor() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_network_predictor_ = false;
   NotifyAndDeleteIfDone();
 }
 
-void BrowsingDataRemover::ClearNetworkPredictorOnIOThread() {
+void BrowsingDataRemover::ClearNetworkPredictorOnIOThread(
+    chrome_browser_net::Predictor* predictor) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
-  chrome_browser_net::Predictor* predictor = profile_->GetNetworkPredictor();
-  if (predictor) {

[Mike West, 2014/06/10 12:33:13]

Can this be null? If not, can we DCHECK?

[engedy, 2014/06/10 15:19:40]

Indeed, this must be non-NULL, otherwise the method would not be called. Added a
DCHECK.

-    predictor->DiscardInitialNavigationHistory();
-    predictor->DiscardAllResults();
-  }
+  predictor->DiscardInitialNavigationHistory();
+  predictor->DiscardAllResults();
 
   // Notify the UI thread that we are done.
   BrowserThread::PostTask(
       BrowserThread::UI,
       FROM_HERE,
       base::Bind(&BrowsingDataRemover::OnClearedNetworkPredictor,
                  base::Unretained(this)));
 }
 
 void BrowsingDataRemover::OnClearedNetworkingHistory() {
@@ skipping 261 matching lines @@
   waiting_for_clear_webrtc_logs_ = false;
   NotifyAndDeleteIfDone();
 }
 #endif
 
 void BrowsingDataRemover::OnClearedDomainReliabilityMonitor() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   waiting_for_clear_domain_reliability_monitor_ = false;
   NotifyAndDeleteIfDone();
 }