Issue 328683004: Merge 270621 "Fixes the crash when the transient parent is NULL."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328683004: Merge 270621 "Fixes the crash when the transient parent is NULL." (Closed)

Created:
6 years, 6 months ago by Jun Mukai

Modified:
6 years, 6 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

Merge 270621 "Fixes the crash when the transient parent is NULL." > Fixes the crash when the transient parent is NULL. > > I couldn't find the actual repro steps but anyways the method > signature of ui/shell_dialogs/select_file_dialog.h says that > the parent could be NULL. > > BUG=373522 > R=erg@chromium.org > TEST=None > > Review URL: https://codereview.chromium.org/283303002 TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276073

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	chrome/browser/ui/libgtk2ui/gtk2_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/libgtk2ui/gtk2_util.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r276073.