Issue 283303002: Fixes the crash when the transient parent is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283303002: Fixes the crash when the transient parent is NULL. (Closed)

Created:
6 years, 7 months ago by Jun Mukai

Modified:
6 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes the crash when the transient parent is NULL. I couldn't find the actual repro steps but anyways the method signature of ui/shell_dialogs/select_file_dialog.h says that the parent could be NULL. BUG=373522 R=erg@chromium.org TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270621

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	chrome/browser/ui/libgtk2ui/gtk2_util.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/libgtk2ui/gtk2_util.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Elliot Glaysher

sorta weird that we have places where we have a NULL parent window. lgtm

6 years, 7 months ago (2014-05-15 00:36:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/283303002/1

6 years, 7 months ago (2014-05-15 00:51:40 UTC) #4

Message was sent while issue was closed.

Change committed as 270621