Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

Issue 328683004: Merge 270621 "Fixes the crash when the transient parent is NULL." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1985/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
===================================================================
--- chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc (revision 276072)
+++ chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc (working copy)
@@ -242,7 +242,8 @@
// TODO(mukai): take care of parent as select_file_dialog_impl_gtk2.
dialog_ = gtk_print_unix_dialog_new(NULL, NULL);
libgtk2ui::SetGtkTransientForAura(dialog_, parent_view);
- parent_view->AddObserver(this);
+ if (parent_view)
+ parent_view->AddObserver(this);
g_signal_connect(dialog_, "delete-event",
G_CALLBACK(gtk_widget_hide_on_delete), NULL);
« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698