Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328663007: Delete JavaScriptAction, preferring to implement the 1-line logic in (Closed)

Created:
6 years, 6 months ago by chrishenry
Modified:
6 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Delete JavaScriptAction, preferring to implement the 1-line logic in ActionRunner instead. Rename parameter to ExecuteJavaScript (both in action_runner.py and web_contents.py) from expr/expression to statement. BUG=361809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M tools/telemetry/telemetry/core/web_contents.py View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 2 chunks +4 lines, -5 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/javascript.py View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
chrishenry
6 years, 6 months ago (2014-06-10 17:00:44 UTC) #1
nednguyen
lgtm
6 years, 6 months ago (2014-06-10 17:33:28 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-10 17:33:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/328663007/1
6 years, 6 months ago (2014-06-10 17:36:55 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 02:43:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 08:44:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18829)
6 years, 6 months ago (2014-06-11 08:44:26 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-11 12:40:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/328663007/1
6 years, 6 months ago (2014-06-11 12:41:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 14:03:09 UTC) #10
Message was sent while issue was closed. 
Change committed as 276386

Powered by Google App Engine
This is Rietveld 408576698