Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: tools/telemetry/telemetry/core/web_contents.py

Issue 328663007: Delete JavaScriptAction, preferring to implement the 1-line logic in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/actions/action_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/web_contents.py
diff --git a/tools/telemetry/telemetry/core/web_contents.py b/tools/telemetry/telemetry/core/web_contents.py
index c5137679de7a383edfe192a8c4eb1089f242cba7..6ebdf24ef6e7dd28e227f326b48fcba2b854b57a 100644
--- a/tools/telemetry/telemetry/core/web_contents.py
+++ b/tools/telemetry/telemetry/core/web_contents.py
@@ -84,13 +84,13 @@ class WebContents(object):
"window.__telemetry_testHasReachedNetworkQuiescence()"))
return has_reached_quiescence
- def ExecuteJavaScript(self, expr, timeout=DEFAULT_WEB_CONTENTS_TIMEOUT):
- """Executes expr in JavaScript. Does not return the result.
+ def ExecuteJavaScript(self, statement, timeout=DEFAULT_WEB_CONTENTS_TIMEOUT):
+ """Executes statement in JavaScript. Does not return the result.
- If the expression failed to evaluate, EvaluateException will be raised.
+ If the statement failed to evaluate, EvaluateException will be raised.
"""
return self.ExecuteJavaScriptInContext(
- expr, context_id=None, timeout=timeout)
+ statement, context_id=None, timeout=timeout)
def EvaluateJavaScript(self, expr, timeout=DEFAULT_WEB_CONTENTS_TIMEOUT):
"""Evalutes expr in JavaScript and returns the JSONized result.
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/actions/action_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698