tools/telemetry/telemetry/page/actions/javascript.py - Issue 328663007: Delete JavaScriptAction, preferring to implement the 1-line logic in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/javascript.py

Issue 328663007: Delete JavaScriptAction, preferring to implement the 1-line logic in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/actions/javascript.py

diff --git a/tools/telemetry/telemetry/page/actions/javascript.py b/tools/telemetry/telemetry/page/actions/javascript.py

deleted file mode 100644

index 8a0bb092f3290899ae0c95ffbe906ab2a0a6f728..0000000000000000000000000000000000000000

--- a/tools/telemetry/telemetry/page/actions/javascript.py

+++ /dev/null

@@ -1,14 +0,0 @@

-# Use of this source code is governed by a BSD-style license that can be

-# found in the LICENSE file.

-from telemetry.page.actions import page_action

-class JavaScriptAction(page_action.PageAction):

- def __init__(self, attributes=None):

- super(JavaScriptAction, self).__init__(attributes)

- def RunAction(self, tab):

- assert hasattr(self, 'expression')

- tab.ExecuteJavaScript(self.expression)

« no previous file with comments | « tools/telemetry/telemetry/page/actions/action_runner.py ('k') | no next file » | no next file with comments »