Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum. (Closed)

Created:
6 years, 6 months ago by yoichio

Modified:
6 years, 6 months ago

Reviewers:
tkent, yosin_UTC9

CC:
blink-reviews, groby+blinkspell_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Change a FrameSelection::setSelectedRange argument type from bool to enum. Let's use FrameSelection::DirectoinalOption instead of bool. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176192

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	Source/core/editing/EditorCommand.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/FrameSelection.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/editing/FrameSelection.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/InputMethodController.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/DOMSelection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/328243004/1

6 years, 6 months ago (2014-06-16 08:16:35 UTC) #5

Message was sent while issue was closed.

Change committed as 176192