Source/core/page/DOMSelection.cpp - Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DOMSelection.cpp

Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DOMSelection.cpp

diff --git a/Source/core/page/DOMSelection.cpp b/Source/core/page/DOMSelection.cpp

index e98d6fba7d52a6dbd0daa1a0e11f4742fb0a5440..c4cc8aff20334d4363c4317ce3919267c2591fe3 100644

--- a/Source/core/page/DOMSelection.cpp

+++ b/Source/core/page/DOMSelection.cpp

@@ -214,7 +214,7 @@ void DOMSelection::collapse(Node* node, int offset, ExceptionState& exceptionSta

range->setEnd(node, offset, exceptionState);

if (exceptionState.hadException())

return;

- m_frame->selection().setSelectedRange(range.get(), DOWNSTREAM, m_frame->selection().isDirectional());

+ m_frame->selection().setSelectedRange(range.get(), DOWNSTREAM, m_frame->selection().isDirectional() ? FrameSelection::Directional : FrameSelection::NonDirectional);

}

void DOMSelection::collapse(Node* node, ExceptionState& exceptionState)

« no previous file with comments | « Source/core/editing/InputMethodController.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »