Source/web/WebLocalFrameImpl.cpp - Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 328243004: Change a FrameSelection::setSelectedRange argument type from bool to enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 2ae1d665fc392785ed1eb176e8f1df7ab5a2ffda..1cbf30e68a25e1f1cbcbdd98e4778d355eefd253 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1271,7 +1271,7 @@ void WebLocalFrameImpl::selectRange(const WebPoint& base, const WebPoint& extent

void WebLocalFrameImpl::selectRange(const WebRange& webRange)

{

if (RefPtrWillBeRawPtr<Range> range = static_cast<PassRefPtrWillBeRawPtr<Range> >(webRange))

- frame()->selection().setSelectedRange(range.get(), WebCore::VP_DEFAULT_AFFINITY, false, NotUserTriggered);

+ frame()->selection().setSelectedRange(range.get(), WebCore::VP_DEFAULT_AFFINITY, FrameSelection::NonDirectional, NotUserTriggered);

}

void WebLocalFrameImpl::moveRangeSelection(const WebPoint& base, const WebPoint& extent)

« no previous file with comments | « Source/core/page/DOMSelection.cpp ('k') | no next file » | no next file with comments »