Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 328113003: Revert "Password bubble: Add an "active" icon state, and a new disabled icon." (Closed)

Created:
6 years, 6 months ago by alph
Modified:
6 years, 6 months ago
Reviewers:
Mike West
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Revert "Password bubble: Add an "active" icon state, and a new disabled icon." This reverts commit c21df41fea3396ffc1d9672e461c6b42a69625ee. r276284 Broke PendingState test http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11531 TBR=mkwst@chromium.org NOTRY=true BUG=261628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -56 lines) Patch
A chrome/app/theme/default_100_percent/common/blocked_save_passwords.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/common/save_password.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/save_password_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/save_password_disabled_active.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/save_password_disabled_inactive.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/save_password_inactive.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/blocked_save_passwords.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/save_password.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/save_password_active.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/save_password_disabled_active.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/save_password_disabled_inactive.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/save_password_inactive.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_icon.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_ui_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc View 1 chunk +3 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
alph
6 years, 6 months ago (2014-06-11 08:18:36 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r276302 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698