chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 328113003: Revert "Password bubble: Add an "active" icon state, and a new disabled icon."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 328113003: Revert "Password bubble: Add an "active" icon state, and a new disabled icon." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index 9cbd290acd9104a80c772839c5873e83ea466cb8..3bf1d8c016a33f8c66bfa7bae8d80e07808d34c8 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -109,8 +109,10 @@ void ManagePasswordsUIController::OnLoginsChanged(

if (it->type() == password_manager::PasswordStoreChange::REMOVE) {

password_form_map_.erase(changed_form.username_value);

- if (changed_form.blacklisted_by_user)

+ if (changed_form.blacklisted_by_user) {

+ DCHECK(state_ == password_manager::ui::BLACKLIST_STATE);

state_ = password_manager::ui::MANAGE_STATE;

+ }

} else {

new_password_forms_.push_back(new autofill::PasswordForm(changed_form));

password_form_map_[changed_form.username_value] =