chrome/browser/ui/passwords/manage_passwords_icon.cc - Issue 328113003: Revert "Password bubble: Add an "active" icon state, and a new disabled icon."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_icon.cc

Issue 328113003: Revert "Password bubble: Add an "active" icon state, and a new disabled icon." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_icon.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_icon.cc b/chrome/browser/ui/passwords/manage_passwords_icon.cc

index 26f2a011ff481fa00d753f522d14eefc46f5b9ca..cba65c1ce7787a8fb72486f6452ec09d423a066f 100644

--- a/chrome/browser/ui/passwords/manage_passwords_icon.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_icon.cc

@@ -5,20 +5,12 @@

#include "chrome/browser/ui/passwords/manage_passwords_icon.h"

ManagePasswordsIcon::ManagePasswordsIcon()

- : state_(password_manager::ui::INACTIVE_STATE),

- active_(false) {

+ : state_(password_manager::ui::INACTIVE_STATE) {

}

ManagePasswordsIcon::~ManagePasswordsIcon() {

}

-void ManagePasswordsIcon::SetActive(bool active) {

- if (active_ == active)

- return;

- active_ = active;

- UpdateVisibleUI();

void ManagePasswordsIcon::SetState(password_manager::ui::State state) {

if (state_ == state)

return;