Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 327593003: Sync FakeServer cleanup: CHECKs and logging info (Closed)

Created:
6 years, 6 months ago by pval...(no longer on Chromium)
Modified:
6 years, 6 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Sync FakeServer cleanup: CHECKs and logging info This CL removes unnecessary DCHECKs, switches useful DCHECKs to CHECKS, and adds logging statements. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276171

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M sync/test/fake_server/fake_server.cc View 2 3 chunks +4 lines, -3 lines 0 comments Download
M sync/test/fake_server/fake_server_entity.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M sync/test/fake_server/permanent_entity.h View 1 chunk +1 line, -2 lines 0 comments Download
M sync/test/fake_server/permanent_entity.cc View 2 3 chunks +13 lines, -12 lines 0 comments Download
M sync/test/fake_server/unique_client_entity.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pval...(no longer on Chromium)
6 years, 6 months ago (2014-06-09 20:59:45 UTC) #1
rlarocque
I think there's a style preference written down somewhere that says we'd prefer to not ...
6 years, 6 months ago (2014-06-09 21:28:49 UTC) #2
pval...(no longer on Chromium)
Ok, I'm onboard for no CHECKs. The style guide and past discussions on this make ...
6 years, 6 months ago (2014-06-09 23:29:27 UTC) #3
pval...(no longer on Chromium)
back to CHECKs after an offline discussion, PTAL
6 years, 6 months ago (2014-06-10 00:38:15 UTC) #4
rlarocque
On 2014/06/10 00:38:15, pvalenzuela wrote: > back to CHECKs after an offline discussion, PTAL lgtm.
6 years, 6 months ago (2014-06-10 00:54:24 UTC) #5
pval...(no longer on Chromium)
The CQ bit was checked by pvalenzuela@chromium.org
6 years, 6 months ago (2014-06-10 00:56:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pvalenzuela@chromium.org/327593003/60001
6 years, 6 months ago (2014-06-10 00:57:06 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 19:28:52 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 22:00:55 UTC) #9
Message was sent while issue was closed.
Change committed as 276171

Powered by Google App Engine
This is Rietveld 408576698