Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: sync/test/fake_server/unique_client_entity.cc

Issue 327593003: Sync FakeServer cleanup: CHECKs and logging info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/permanent_entity.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/unique_client_entity.cc
diff --git a/sync/test/fake_server/unique_client_entity.cc b/sync/test/fake_server/unique_client_entity.cc
index 693b24a2c89b143f48a6db298b350e61614c1bf2..e9ce2e917ab0f72eb56839c82d345c7de2e648b6 100644
--- a/sync/test/fake_server/unique_client_entity.cc
+++ b/sync/test/fake_server/unique_client_entity.cc
@@ -23,9 +23,8 @@ UniqueClientEntity::~UniqueClientEntity() { }
// static
FakeServerEntity* UniqueClientEntity::CreateNew(
const sync_pb::SyncEntity& client_entity) {
- DCHECK(client_entity.has_client_defined_unique_tag());
- DCHECK(!client_entity.folder());
- DCHECK(!client_entity.deleted());
+ CHECK(client_entity.has_client_defined_unique_tag())
+ << "A UniqueClientEntity must have a client-defined unique tag.";
ModelType model_type =
syncer::GetModelTypeFromSpecifics(client_entity.specifics());
string id = client_entity.version() == 0 ?
« no previous file with comments | « sync/test/fake_server/permanent_entity.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698