Sync FakeServer cleanup: CHECKs and logging info

sync/test/fake_server/fake_server_entity.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/test/fake_server/fake_server_entity.h"
 
 #include <limits>
 #include <string>
 #include <vector>
 
@@ skipping 69 matching lines @@
                                    const ModelType& model_type,
                                    int64 version,
                                    const string& name)
       : id_(id),
         model_type_(model_type),
         version_(version),
         name_(name) {}
 
 void FakeServerEntity::SerializeBaseProtoFields(
     sync_pb::SyncEntity* sync_entity) {
-  DCHECK(sync_entity);
+  CHECK(sync_entity);

[rlarocque, 2014/06/09 21:28:48]

See CL-level comment.

[pval...(no longer on Chromium), 2014/06/09 23:29:27]

sounds good. removed.

 
   // FakeServerEntity fields
   sync_entity->set_id_string(id_);
   sync_entity->set_version(version_);
   sync_entity->set_name(name_);
 
   // Data via accessors
   sync_entity->set_deleted(IsDeleted());
   sync_entity->set_folder(IsFolder());
 }
 
 }  // namespace fake_server