Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
epoger
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). BUG=None TEST=make tools tests && out/Debug/tests R=epoger@google.com Committed: https://skia.googlesource.com/skia/+/da4ed3289ec05a7155d5669c90a743a829574ea6

Patch Set 1 #

Patch Set 2 : forgot some places #

Total comments: 1

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -48 lines) Patch
M gyp/tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tests/PictureUtilsTest.cpp View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M tools/CopyTilesRenderer.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/filtermain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/picture_utils.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tools/picture_utils.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M tools/render_pdfs_main.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/render_pictures_main.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
6 years, 6 months ago (2014-06-11 23:58:02 UTC) #1
epoger
Should be fine, once you: - fix the line wrap (I think there was only ...
6 years, 6 months ago (2014-06-12 01:39:45 UTC) #2
tfarina
All done. ptal.
6 years, 6 months ago (2014-06-12 02:56:39 UTC) #3
epoger
LGTM at patchset 3 Thanks for the cleanup!
6 years, 6 months ago (2014-06-12 03:03:35 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-12 15:21:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/327403002/40001
6 years, 6 months ago (2014-06-12 15:22:57 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 15:51:02 UTC) #7
Message was sent while issue was closed.
Change committed as da4ed3289ec05a7155d5669c90a743a829574ea6

Powered by Google App Engine
This is Rietveld 408576698