tools/bench_pictures_main.cpp - Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/bench_pictures_main.cpp

Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/bench_pictures_main.cpp

diff --git a/tools/bench_pictures_main.cpp b/tools/bench_pictures_main.cpp

index 4d4116db011b67c940463e39376e8a1b0ddd5ccf..c267c4cb9ba0f05598b8fdee8cc7259bc5b9071f 100644

--- a/tools/bench_pictures_main.cpp

+++ b/tools/bench_pictures_main.cpp

@@ -374,8 +374,7 @@ static int process_input(const char* input,

int failures = 0;

if (iter.next(&inputFilename)) {

do {

- SkString inputPath;

- sk_tools::make_filepath(&inputPath, inputAsSkString, inputFilename);

+ SkString inputPath = SkOSPath::SkPathJoin(input, inputFilename.c_str());

if (!run_single_benchmark(inputPath, benchmark)) {

++failures;

}

« no previous file with comments | « tools/CopyTilesRenderer.cpp ('k') | tools/filtermain.cpp » ('j') | no next file with comments »