tools/lua/lua_pictures.cpp - Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lua/lua_pictures.cpp

Issue 327403002: Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin(). (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/lua/lua_pictures.cpp

diff --git a/tools/lua/lua_pictures.cpp b/tools/lua/lua_pictures.cpp

index f1c5ce920f0c720868a5b33102bc0f0621390a60..2985bf64c31323471250124b486b694ad026fdd2 100644

--- a/tools/lua/lua_pictures.cpp

+++ b/tools/lua/lua_pictures.cpp

@@ -132,7 +132,7 @@ int tool_main(int argc, char** argv) {

SkString filename;

SkOSFile::Iter iter(FLAGS_skpPath[i], "skp");

while(iter.next(&filename)) {

- sk_tools::make_filepath(&paths.push_back(), directory, filename);

+ paths.push_back() = SkOSPath::SkPathJoin(directory.c_str(), filename.c_str());

}

} else {

// Add this as an .skp itself.

« no previous file with comments | « tools/filtermain.cpp ('k') | tools/picture_utils.h » ('j') | no next file with comments »