Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed)

Created:
6 years, 6 months ago by Shu Chen
Modified:
6 years, 6 months ago
Reviewers:
Avi (use Gerrit), nasko
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. BUG=377169 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276667

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : debug. #

Patch Set 4 : fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -206 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 3 chunks +13 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +8 lines, -28 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +6 lines, -8 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 4 chunks +26 lines, -28 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 6 chunks +4 lines, -47 lines 0 comments Download
M content/test/test_render_view_host.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Shu Chen
avi@/nasko@, can you please help to review this cl? Thanks
6 years, 6 months ago (2014-06-11 17:36:22 UTC) #1
Avi (use Gerrit)
This LGTM to me.
6 years, 6 months ago (2014-06-11 18:02:31 UTC) #2
nasko
LGTM
6 years, 6 months ago (2014-06-11 20:08:00 UTC) #3
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-12 08:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/326403002/60001
6 years, 6 months ago (2014-06-12 08:35:03 UTC) #5
commit-bot: I haz the power
Change committed as 276667
6 years, 6 months ago (2014-06-12 14:26:49 UTC) #6
Shu Chen
6 years, 2 months ago (2014-10-09 01:46:47 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/644583002/ by shuchen@chromium.org.

The reason for reverting is: Suspecting the cause of regression
crbug.com/417152..

Powered by Google App Engine
This is Rietveld 408576698