content/browser/renderer_host/render_widget_host_view_android.h - Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index ecab46d345a3a5de8d4746c888517ef2acc378a9..31c344d09dbe2a732e364d0c4152e89b9916cb46 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -100,9 +100,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

virtual float GetOverdrawBottomHeight() const OVERRIDE;

virtual void UpdateCursor(const WebCursor& cursor) OVERRIDE;

virtual void SetIsLoading(bool is_loading) OVERRIDE;

- virtual void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode input_mode,

- bool can_compose_inline) OVERRIDE;

+ virtual void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) OVERRIDE;

virtual void ImeCancelComposition() OVERRIDE;

virtual void FocusedNodeChanged(bool is_editable_node) OVERRIDE;

virtual void RenderProcessGone(base::TerminationStatus status,

@@ -193,7 +192,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

void SendMouseWheelEvent(const blink::WebMouseWheelEvent& event);

void SendGestureEvent(const blink::WebGestureEvent& event);

- void OnTextInputStateChanged(const ViewHostMsg_TextInputState_Params& params);

void OnDidChangeBodyBackgroundColor(SkColor color);

void OnStartContentIntent(const GURL& content_url);

void OnSetNeedsBeginFrame(bool enabled);