content/browser/renderer_host/render_widget_host_view_base.h - Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 07ae5ebede516bd78b8eafa3def8fff1c39b6e4d..f86811a5ad091b6cf18b4f3d761d041b2ff20e83 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -37,8 +37,8 @@ class SkBitmap;

struct AccessibilityHostMsg_EventParams;

struct GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params;

struct GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params;

-struct ViewHostMsg_TextInputState_Params;

struct ViewHostMsg_SelectionBounds_Params;

+struct ViewHostMsg_TextInputState_Params;

namespace media {

class VideoFrame;

@@ -219,9 +219,8 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

virtual void SetIsLoading(bool is_loading) = 0;

// Updates the type of the input method attached to the view.

- virtual void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode mode,

- bool can_compose_inline) = 0;

+ virtual void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) = 0;

// Cancel the ongoing composition of the input method attached to the view.

virtual void ImeCancelComposition() = 0;