GTK: Compute infobubble rects correctly.

GTK: Compute infobubble target rects correctly.

I misunderstood how allocations work in the original
version and wasn't handling the case where there are
intermediate GdkWindows between the target widget and
its toplevel window correctly.

TEST=first-run, bookmark, and browser action bubbles get opened in the correct places under xmonad, metacity, and ion3
BUG=23373
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29978

[use derat at chromium.org, 2009-10-23 20:22:18]

(Note that I haven't been able to repro the placement problems that
you and #1 in http://code.google.com/p/chromium/issues/detail?id=3D23373
describe, so I'd appreciate it if you could try this patch under
xmonad and see if it fixes things for you.)

On Fri, Oct 23, 2009 at 1:18 PM,  <derat@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Description:
> GTK: Compute infobubble target rects correctly.
>
> I misunderstood how allocations work in the original
> version and wasn't handling the case where there are
> intermediate GdkWindows between the target widget and
> its toplevel window correctly.
>
> TEST=3Dfirst-run, bookmark, and browser action bubbles get opened in the
> correct
> places under xmonad, metacity, and ion3
> BUG=3D23373
>
> Please review this at http://codereview.chromium.org/326017
>
> Affected files:
> =A0M chrome/browser/gtk/browser_actions_toolbar_gtk.cc
> =A0M chrome/browser/gtk/location_bar_view_gtk.cc
> =A0M chrome/browser/gtk/toolbar_star_toggle_gtk.cc
> =A0M chrome/common/gtk_util.h
> =A0M chrome/common/gtk_util.cc
>
>
>

[Evan Stade, 2009-10-23 22:18:16]

lgtm, I'm patching it in now.

[Evan Stade, 2009-10-23 22:39:07]

well, my chromium is crashing consistently for me right now, with or without
this patch, so I can't test it, but it looks right.

[Evan Stade, 2009-10-23 22:54:13]

yup, it fixes the positioning