GTK: Compute infobubble rects correctly.

chrome/browser/gtk/location_bar_view_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/location_bar_view_gtk.h"
 
 #include <string>
 
 #include "app/gfx/canvas_paint.h"
 #include "app/gfx/gtk_util.h"
@@ skipping 631 matching lines @@
   gtk_label_set_text(GTK_LABEL(tab_to_search_hint_leading_label_),
                      leading.c_str());
   gtk_label_set_text(GTK_LABEL(tab_to_search_hint_trailing_label_),
                      trailing.c_str());
 }
 
 void LocationBarViewGtk::ShowFirstRunBubbleInternal(bool use_OEM_bubble) {
   if (!location_entry_.get() || !widget()->window)
     return;
 
-  int x = widget()->allocation.x;
-  int y = widget()->allocation.y;
+  gfx::Rect rect = gtk_util::GetWidgetRectRelativeToToplevel(widget());
+  rect.set_width(0);
+  rect.set_height(0);
 
   // The bubble needs to be just below the Omnibox and slightly to the right
   // of star button, so shift x and y co-ordinates.
-  y += widget()->allocation.height + kFirstRunBubbleTopMargin;
+  int y_offset = widget()->allocation.height + kFirstRunBubbleTopMargin;
+  int x_offset = 0;
   if (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT)
-    x += kFirstRunBubbleLeftMargin;
+    x_offset = kFirstRunBubbleLeftMargin;
   else
-    x += widget()->allocation.width - kFirstRunBubbleLeftMargin;
+    x_offset = widget()->allocation.width - kFirstRunBubbleLeftMargin;
+  rect.Offset(x_offset, y_offset);
 
   FirstRunBubble::Show(profile_,
                        GTK_WINDOW(gtk_widget_get_toplevel(widget())),
-                       gfx::Rect(x, y, 0, 0),
+                       rect,
                        use_OEM_bubble);
 }
 
 // static
 gboolean LocationBarViewGtk::OnSecurityIconPressed(
     GtkWidget* sender,
     GdkEventButton* event,
     LocationBarViewGtk* location_bar) {
   TabContents* tab = BrowserList::GetLastActive()->GetSelectedTabContents();
   NavigationEntry* nav_entry = tab->controller().GetActiveEntry();
@@ skipping 144 matching lines @@
   const ExtensionActionState* state =
       contents->GetPageActionState(view->page_action_);
   if (!state || state->badge_text().empty())
     return FALSE;
 
   gfx::CanvasPaint canvas(event, false);
   gfx::Rect bounding_rect(widget->allocation);
   state->PaintBadge(&canvas, bounding_rect);
   return FALSE;
 }