GTK: Compute infobubble rects correctly.

chrome/browser/gtk/browser_actions_toolbar_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_actions_toolbar_gtk.h"
 
 #include <gtk/gtk.h>
 #include <vector>
 
 #include "app/gfx/canvas_paint.h"
 #include "app/gfx/gtk_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/extensions/image_loading_tracker.h"
 #include "chrome/browser/gtk/extension_popup_gtk.h"
 #include "chrome/browser/gtk/gtk_chrome_button.h"
 #include "chrome/browser/gtk/gtk_theme_provider.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/gtk_util.h"
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/notification_type.h"
 
 // The size of each button on the toolbar.
 static const int kButtonSize = 29;
 
 class BrowserActionButton : public NotificationObserver,
                             public ImageLoadingTracker::Observer {
@@ skipping 89 matching lines @@
     }
   }
 
   void OnThemeChanged() {
     gtk_chrome_button_set_use_gtk_rendering(GTK_CHROME_BUTTON(button_.get()),
         GtkThemeProvider::GetFrom(browser_->profile())->UseGtkTheme());
   }
 
   static void OnButtonClicked(GtkWidget* widget, BrowserActionButton* action) {
     if (action->extension_->browser_action()->is_popup()) {
-      ExtensionPopupGtk::Show(action->extension_->browser_action()->popup_url(),
-                              action->browser_, gfx::Rect(widget->allocation));
-
+      ExtensionPopupGtk::Show(
+          action->extension_->browser_action()->popup_url(),
+          action->browser_,
+          gtk_util::GetWidgetRectRelativeToToplevel(widget));
     } else {
       ExtensionBrowserEventRouter::GetInstance()->BrowserActionExecuted(
           action->browser_->profile(), action->extension_->id(),
           action->browser_);
     }
   }
 
   static gboolean OnExposeEvent(GtkWidget* widget,
                                 GdkEventExpose* event,
                                 BrowserActionButton* action) {
@@ skipping 101 matching lines @@
   if (extension_button_map_.erase(extension->id()))
     UpdateVisibility();
 }
 
 void BrowserActionsToolbarGtk::UpdateVisibility() {
   if (button_count() == 0)
     gtk_widget_hide(widget());
   else
     gtk_widget_show(widget());
 }