Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 325313004: Cleanup tests using SetSkipCertificateImporterCreationForTest (Closed)

Created:
6 years, 6 months ago by tbarzic
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup tests using SetSkipCertificateImporterCreationForTest UserNetworkConfigurationUpdater::SetSkipCertificateImporterCreationForTest is not needed anymore, so it's safe to remove it and cleanup tests using it. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283868

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 28

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -159 lines) Patch
M chrome/browser/chromeos/policy/user_network_configuration_updater.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/user_network_configuration_updater.cc View 1 2 4 chunks +4 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc View 1 2 6 chunks +0 lines, -44 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 2 5 chunks +0 lines, -88 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pneubeck (no reviews)
this should be fine to review/commit now?
6 years, 5 months ago (2014-07-15 16:17:13 UTC) #1
tbarzic
yes, this should be ready for review now adding Steven as an owner for chrome/browser/ui/webui/options/
6 years, 5 months ago (2014-07-15 18:33:10 UTC) #2
pneubeck (no reviews)
the removal itself lgtm, some more stuff can be removed though https://codereview.chromium.org/325313004/diff/20001/chrome/browser/chromeos/policy/user_network_configuration_updater.cc File chrome/browser/chromeos/policy/user_network_configuration_updater.cc (right): ...
6 years, 5 months ago (2014-07-15 20:33:36 UTC) #3
tbarzic
https://codereview.chromium.org/325313004/diff/20001/chrome/browser/chromeos/policy/user_network_configuration_updater.cc File chrome/browser/chromeos/policy/user_network_configuration_updater.cc (right): https://codereview.chromium.org/325313004/diff/20001/chrome/browser/chromeos/policy/user_network_configuration_updater.cc#newcode24 chrome/browser/chromeos/policy/user_network_configuration_updater.cc:24: bool skip_certificate_importer_creation_for_test = false; On 2014/07/15 20:33:35, pneubeck wrote: ...
6 years, 5 months ago (2014-07-16 05:58:11 UTC) #4
pneubeck (no reviews)
@Steven, friendly ping
6 years, 5 months ago (2014-07-17 07:30:17 UTC) #5
stevenjb
Sorry, didn't realize this needed me as an owner. LGTM
6 years, 5 months ago (2014-07-17 16:59:41 UTC) #6
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-17 17:42:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/325313004/40001
6 years, 5 months ago (2014-07-17 17:46:09 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:57:41 UTC) #9
Message was sent while issue was closed.
Change committed as 283868

Powered by Google App Engine
This is Rietveld 408576698